Should I buy a silver trumpet or a brass trumpet?

It doesn’t matter!   Silver may look better, but this is cosmetic only.  Whether you choose a silver or brass horn will not impact your ability to play the trumpet or the sound it produces.